Reduce flakiness in single-cluster end-to-end tests #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make failures to find failing jobs easier to troubleshoot.
This adds expectations on existing pods and clearer error messages to ease troubleshooting in case of failing of flaky tests.
Sharding end-to-end tests exhibited flakiness, caused by the git job pod not being present in the cluster by the time checks were run to validate its node selector against that of the relevant shard. To prevent this, tests on the node selector are now run first, which incidentally also prevents `Eventually` from running more times awaiting a config map to be deployed.
manno
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharding end-to-end tests exhibited flakiness, caused by the git job pod
not being present in the cluster by the time checks were run to validate
its node selector against that of the relevant shard.
To prevent this, tests on the node selector are now run first, which
incidentally also prevents
Eventuallyfrom running more loops waitingfor a config map to be deployed.