Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.10] Fix apply defaults from gitrepo restriction #3084

Merged

Conversation

manno
Copy link
Member

@manno manno commented Nov 15, 2024

Refers to #3083

  • Apply defaults from gitrepo restrictions
  • Add unit tests covering defaults auth and assign

* Apply defaults from gitrepo restrictions
* Add unit tests covering defaults auth and assign

This covers a few happy and error cases with unit tests, uncovering a
few typos in error messages in the process.

---------

Co-authored-by: Corentin Néau <[email protected]>
@manno manno requested a review from a team as a code owner November 15, 2024 10:24
manno and others added 3 commits November 15, 2024 13:56
This reflects a recent change in `rancher/fleet-test-data` where we use
distinct values for labels vs annotations.
@manno manno merged commit 5421d74 into release/v0.10 Nov 15, 2024
12 checks passed
@manno manno deleted the v0.10-fix-apply-defaults-from-gitrepo-restriction branch November 15, 2024 13:54
@kkaempf kkaempf added this to the v2.10.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants