Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra image captions #1576

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Remove extra image captions #1576

merged 2 commits into from
Nov 25, 2024

Conversation

btat
Copy link
Contributor

@btat btat commented Nov 20, 2024

Description

The image on high-availability-installs.md has 2 captions with the same text. One with <figcaption>, but the resulting rendering is indistinguishable from regular paragraph text. The other uses <sup> to try and emulate an actual caption. I opted to remove the <figcaption> instance due to the lack of formatting.

On how-monitoring-works.md, there's a figcaption instance that has no image surrounding it.

@btat btat changed the title Remove duplicate image caption Remove extra image captions Nov 22, 2024
Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btat btat merged commit 48c191e into rancher:main Nov 25, 2024
1 check passed
@btat btat deleted the img-caption branch November 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants