[SURE-8832] fix: add check for external rules while updating roleTemplate

[pratikjagrut]

Issue: #1381

Problem

JIRA issue: https://jira.suse.com/browse/SURE-8832
When attempting to update a RoleTemplate using the rancher2 tf provider v4.2.0 you will get the following error:

Error: Bad response statusCode [400]. Status [400 Bad Request]. Body: [baseType=error,
code=BadRequest, message=admission webhook "rancher.cattle.io.roletemplates.management.cattle.io" 
denied the request: ExternalRules can't be set in RoleTemplates with external=false] from 
[https://example.com/v3/roleTemplates/rt-mb28r]

Solution

• Modified the roleTemplate update logic to include a check for external rules.
• Added a condition to ensure external rules are only updated when the external flag is set.
• Set externalRules to nil if the external flag is not set.

Testing

Engineering Testing

Manual Testing

The fix was tested using the reproduction steps, and the issue was resolved.

Automated Testing

QA Testing Considerations

Regressions Considerations

[jiaqiluo]

lgtm

Hi @matttrach, could you help arrange the backporting if it is necessary?

[matttrach]

The code is reasonable here, and the unit tests pass.

[matttrach]

@pratikjagrut would you mind signing your commit? Then I will get this merged into the proper branches.

[pratikjagrut]

@pratikjagrut would you mind signing your commit? Then I will get this merged into the proper branches.

@matttrach I've signed the commit.

[matttrach]

I will backport this to release/v5 and release/v4 in separate PRs.