make must_change_password
attribute immutable after creation
#1422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#45736
Problem
Currently, the
must_change_password
is not immutable. Since rancher doesn't allow to change that option after the user creation, we should handle this from the terraform provider.Solution
Set the
must_change_password
attribute as immutable after creation.Testing
Engineering Testing
Manual Testing
Setup a rancher instance from docker:
In order to test this new attribute I've used the following terraform script to ensure the new user had this attribute set:
Once terraform completed its run, you can login with the new created user
testuser
.Once logged in the UI will show the reset password page.
After that, you can change
must_change_password
attribute, and verify that terraform needs to destroy the resource in order to set the new value.Automated Testing
QA Testing Considerations
Regressions Considerations