default dynamic to false #1427
Merged
default dynamic to false #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqiluo
approved these changes
Oct 18, 2024
matttrach
approved these changes
Nov 7, 2024
|
looks like this needs to be backported to v5 to target Rancher v1.9 |
|
@kinarashah please sign your commits and this is good to merge. |
kinarashah
force-pushed
the
dyntest
branch
2 times, most recently
from
f5f929e to
c1ae386
Compare
matttrach
pushed a commit
to matttrach/terraform-provider-rancher2
that referenced
this pull request
Nov 8, 2024
Co-authored-by: Matt Trachier <[email protected]> (cherry picked from commit a021357)
matttrach
added a commit
that referenced
this pull request
Nov 8, 2024
Co-authored-by: Kinara Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#1426
Solution
I removed default
truefor thedynamicfield to align with the default API settings, which also has the added benefit of resolving the issue of duplicate entries being added.Manual Testing
rancher-restrictedtorancher-privilegedand made sure it worked without causing the cluster to error out with the messagesecret xxxx-psact does not contain the expected content.