Add OutBound Type to aks_config_v2 #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
approved these changes
Nov 11, 2024
| ) | ||
|
|
||
| const ( | ||
| clusterAKSV2Kind = "aksV2" | ||
| clusterDriverAKSV2 = "AKS" | ||
| ) | ||
|
|
||
| var ( | ||
| clusterAKSOutboundType = []string{"loadBalancer", "managedNATGateway", "userAssignedNATGateway", "userDefinedRouting"} |
There was a problem hiding this comment.
Optional suggestion: Not sure if these are case sensitive (probably not) but maybe we should match these to how they appear in the Azure docs i.e. managedNatGateway and userAssignedNatGateway.
There was a problem hiding this comment.
it is non case sensitive
| Optional: true, | ||
| Default: "loadBalancer", | ||
| Description: "The AKS outbound type for the egress traffic", | ||
| ValidateFunc: validation.StringInSlice(clusterAKSOutboundType, true), |
There was a problem hiding this comment.
TIL about validation.StringInSlice 👍
There was a problem hiding this comment.
validation function has already non case sensitive flag enabled
mjura
force-pushed
the
aks-outboundtype
branch
2 times, most recently
from
eb769cb to
0a6ffb3
Compare
matttrach
approved these changes
Nov 12, 2024
mjura
force-pushed
the
aks-outboundtype
branch
2 times, most recently
from
edb1e9f to
dc9f154
Compare
Issue: rancher/aks-operator#721 Signed-off-by: Michal Jura <[email protected]>
mjura
force-pushed
the
aks-outboundtype
branch
from
dc9f154 to
836cda8
Compare
This was referenced Nov 14, 2024
matttrach
pushed a commit
to matttrach/terraform-provider-rancher2
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Michal Jura <[email protected]> (cherry picked from commit 51db8c5)
matttrach
added a commit
that referenced
this pull request
Nov 15, 2024
Co-authored-by: Michal Jura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/aks-operator#721
Issue:
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations