-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow to perform manual ETCD snapshots #856
Open
Danil-Grigorev
wants to merge
3
commits into
rancher:main
Choose a base branch
from
Danil-Grigorev:etcd-machine-snapshot-manual
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
✨ Allow to perform manual ETCD snapshots #856
Danil-Grigorev
wants to merge
3
commits into
rancher:main
from
Danil-Grigorev:etcd-machine-snapshot-manual
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
added
area/etcdsnapshot-restore
Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature
kind/feature
labels
Nov 15, 2024
alexander-demicev
previously approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looks good to me
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
etcd-machine-snapshot-manual
branch
from
November 25, 2024 12:03
2eb710f
to
b07a881
Compare
4 tasks
alexander-demicev
approved these changes
Nov 27, 2024
yiannistri
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/etcdsnapshot-restore
Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature
kind/feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR completes the initial setup of the controller with functionality to create manual snapshots on user demand, using the
system-agent
and RKE2 cli, following the docs.This comes with some problems, like inability to specifically name the snapshot and deterministically connect it to the
ETCDMachineSnapshot
replica, created by the user, but the issue lays in lacking options ink3s/rke2
CLI. In the scenario when the snapshot is named “my-snapshot”, the actual name looks like:local-my-snapshot-rke2-control-plane-mnf8z-1731675906-31aa01
and may easily overlap with a snapshot named as just “snapshot”. (Edit: currently matches againstsnapshotName
andmachineName
)This also makes it hard to connect the
creationTimestamp
of the snapshot on the child cluster with the originally invokedETCDMachineSnapshot
resource execution, as no additional info can be stored on the snapshot instance when calling the CLI. (Edit: storing snapshot timestamp in the list now)Final snapshot location and other infor is created and is available on the list within the automatic snapshot record (one per cluster).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #725
Special notes for your reviewer:
Checklist: