bring code up to speed #9
Conversation
|
The For your merge consideration. |
index.js
Outdated
| @@ -111,12 +113,12 @@ Store.prototype._write = function (req) { | |||
| }) | |||
|
|
|||
| function write (store, offsets, buffers) { | |||
| var block | |||
| var block = null; | |||
There was a problem hiding this comment.
Good catch, yes undefined is ok. This was from earlier efforts to troubleshoot issues
package.json
Outdated
| @@ -32,6 +31,9 @@ | |||
| "browser", | |||
| "storage" | |||
| ], | |||
| "engines": { | |||
| "node": ">=12.0.0" | |||
| }, | |||
There was a problem hiding this comment.
I'm trying to remember why I added this. I re-ran the tests with the engine removed, passes all tests. So I'll remove accordingly.
|
@substack Would you mind adding me as a collaborator on NPM so I can merge and publish this? |
|
Or add @soyuka for that matter. :P |
|
I can merge @RangerMauve :) I was waiting for another approval. I doubt I can bump this on npm though. |
|
Thanks @DougAnderson444 ! |
After having some issues with
random-access-webI tried to userandom-access-idbas a workaround which also was problematic, I was seeing that same issues as #6 and #7. I tried to use substack's version too, but also had issues like not being able to write after reloading the browser.This PR is the start of trying to get this code to work flawlessly in the browser.
I brought some of the code differences between this repo and substack's which will hopefully fix some of the issues (notably #6 and possibly #7 , I haven't got that far yet, I need time to check the tests). Notably this commit. So that code is brought into this R-A-S repo in this pull.
Also the tests weren't working for me, so I edited the code so that they work with
browser-run.I made the v 1.3.0 to reflect these changes.
Hopefully there's more to come.