resubmit to CRAN

.Rbuildignore

@@ -15,3 +15,4 @@ cran-comments.md
 ^Meta$
 ^CRAN-RELEASE$
 ^cran-comments\.md$
+^CRAN-SUBMISSION$

R/dplyr-joins.R

@@ -1,8 +1,3 @@
-#-------------------------------------------------------------------------------
-# LEFT JOIN --------------------------------------------------------------------
-#-------------------------------------------------------------------------------
-
-
 #' Left join two data frames
 #'
 #' This is a `joyn` wrapper that works in a similar
@@ -21,10 +16,11 @@
 #'   in `y`, and "z" in both tables.
 #' @inheritParams dplyr::left_join
 #' @inheritParams joyn
-#' @inheritDotParams joyn y_vars_to_keep update_values update_NAs reportvar
-#'   reporttype keep_common_vars verbose
+#' @inheritDotParams joyn
 #'
-#' @return data frame
+#' @family dplyr alternatives
+#' @return An data frame of the same class as `x`. The properties of the output
+#' are as close as possible to the ones returned by the dplyr alternative.
 #' @export
 #'
 #' @examples
@@ -142,10 +138,6 @@ left_join <- function(
   lj
 }
 
-#-------------------------------------------------------------------------------
-# RIGHT JOIN --------------------------------------------------------------------
-#-------------------------------------------------------------------------------
-
 #' Right join two data frames
 #'
 #' This is a `joyn` wrapper that works in a similar
@@ -164,10 +156,10 @@ left_join <- function(
 #'   in `y`, and "z" in both tables.
 #' @inheritParams dplyr::right_join
 #' @inheritParams joyn
-#' @inheritDotParams joyn y_vars_to_keep update_values update_NAs reportvar
-#'   reporttype keep_common_vars verbose
+#' @inheritDotParams joyn
 #'
-#' @return data frame
+#' @family dplyr alternatives
+#' @inherit left_join return
 #' @export
 #'
 #' @examples
@@ -287,12 +279,6 @@ right_join <- function(
 
 }
 
-
-#-------------------------------------------------------------------------------
-# FULL JOIN --------------------------------------------------------------------
-#-------------------------------------------------------------------------------
-
-
 #' Full join two data frames
 #'
 #' This is a `joyn` wrapper that works in a similar
@@ -311,10 +297,11 @@ right_join <- function(
 #'   in `y`, and "z" in both tables.
 #' @inheritParams dplyr::full_join
 #' @inheritParams joyn
-#' @inheritDotParams joyn y_vars_to_keep update_values update_NAs reportvar
-#'   reporttype keep_common_vars verbose
+#' @inheritDotParams joyn
+#'
+#' @family dplyr alternatives
 #'
-#' @return data frame
+#' @inherit left_join return
 #' @export
 #'
 #' @examples
@@ -442,15 +429,10 @@ full_join <- function(
 }
 
 
-#-------------------------------------------------------------------------------
-# INNER JOIN --------------------------------------------------------------------
-#-------------------------------------------------------------------------------
-
-
 #' Inner join two data frames
 #'
-#' This is a `joyn` wrapper that works in a similar
-#' fashion to [dplyr::inner_join]
+#' This is a `joyn` wrapper that works in a similar fashion to
+#' [dplyr::inner_join]
 #'
 #' @param x data frame: referred to as *left* in R terminology, or *master* in
 #'   Stata terminology.
@@ -461,16 +443,15 @@ full_join <- function(
 #'   the two tables. A message lists the variables so that you can check they're
 #'   correct (to suppress the message, simply explicitly list the variables that
 #'   you want to join). To join by different variables on x and y use a vector
-#'   of expressions. For example, `by = c("a = b", "z")` will use "a" in `x`, "b"
-#'   in `y`, and "z" in both tables.
+#'   of expressions. For example, `by = c("a = b", "z")` will use "a" in `x`,
+#'   "b" in `y`, and "z" in both tables.
 #' @inheritParams dplyr::inner_join
 #' @inheritParams joyn
-#' @inheritDotParams joyn y_vars_to_keep update_values update_NAs reportvar
-#'   reporttype keep_common_vars verbose
+#' @inheritDotParams joyn
 #'
-#' @return data frame
+#' @family dplyr alternatives
 #' @export
-#'
+#' @inherit left_join return
 #' @examples
 #' # Simple full join
 #' library(data.table)

cran-comments.md

@@ -1,24 +1,25 @@
 # version 0.2.0
 
-When I run `devtools::check()` I get no errors, warnings, or notes. 
 0 errors | 0 warnings | 0 notes
 
-Yet, when I run `devtools::check(remote = TRUE, manual = TRUE)` I get one note. 
-0 errors ✔ | 0 warnings ✔ | 1 note ✖
-
-The note reads as follows: 
+## revdepcheck results
 
+We checked 0 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
 
+ * We saw 0 new problems
+ * We failed to check 0 packages
 
 ## Resubmission
-This is a resubmission. In this version I have:
-
-* Added trailing slashes to the URLs that I think are failing. I apologize, but 
-I don't understand the problem with the URL. According to the CRAN email, there 
-is a problem with the codecov url in one of the badges of the readme file. I 
-am using the very same url structure of very-well known packages like dplyr or
-tidyr. In case it fails again, could you please expand on the details of 
-the problem? Thanks. 
+This is a resubmission. In this version We have fixed the following notes:
+Found the following HTML validation problems:
+full_join.html:303:1 (full_join.Rd:179): Warning: trimming empty <dt>
+inner_join.html:303:1 (inner_join.Rd:179): Warning: trimming empty <dt>
+left_join.html:303:1 (left_join.Rd:179): Warning: trimming empty <dt>
+right_join.html:303:1 (right_join.Rd:179): Warning: trimming empty <dt>
+
+These notes were created because there was a typo in our roxigen comments. They has been fixed. All check are still passing:
+
+0 errors ✔ | 0 warnings ✔ | 0 notes ✔
 
 
 # version 0.1.4