Upload_values_fix #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zander-prinsloo
approved these changes
Feb 29, 2024
| vary_na = !missing_cases(get(y.var))) | ||
|
|
||
| varx_na = !missing_cases(mget(x.var)), | ||
| vary_na = !missing_cases(mget(y.var))) | ||
|
|
||
| # let `use_util_reportvar` reflect updates | ||
| # FALSE => is NA and not 2, 4 => NA updated |
There was a problem hiding this comment.
@randrescastaneda , here we replace NAs in x with values in y. This should not happen in update_values() only in update_NAs()
tests/testthat/test-update_values.R
Outdated
|
|
||
| # Updating values in x2$x with values from y2$x | ||
| res <- update_values(dt, | ||
| var = "x", | ||
| reportvar = ".joyn") | ||
| # check not updated values | ||
| which(is.na(res$x.x) & res$.joyn != 2) |> |
There was a problem hiding this comment.
No values in x should be updated here for dt. Because every row in x either has an NA or the corresponding row in y has an NA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
update_values()andupdates_NAs()where they were not updating multiple variables.