Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #293: re-throwing exception instead of returning null #294

Merged
merged 2 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -146,29 +146,33 @@ private FileObject getTemplateFile(Element element)
}
}

private Collection<? extends Configuration> getConfiguration(TypeMirror type)
Collection<? extends Configuration> getConfiguration(TypeMirror type)
{
try
{
return getClass(type).getDeclaredConstructor().newInstance();
}
catch (@SuppressWarnings("unused") Exception exception)
catch (Exception exception)
{
return null;
if (exception instanceof RuntimeException)
{
throw (RuntimeException)exception;
}
throw new RuntimeException(exception);
}
}

private Class<? extends Collection<? extends Configuration>> getClass(TypeMirror type)
Class<? extends Collection<? extends Configuration>> getClass(TypeMirror type)
{
try
{
@SuppressWarnings("unchecked")
Class<? extends Collection<? extends Configuration>> configurationClass = (Class<? extends Collection<? extends Configuration>>)Class.forName(type.toString());
return configurationClass;
}
catch (@SuppressWarnings("unused") ClassNotFoundException classNotFound)
catch (ClassNotFoundException classNotFound)
{
return null;
throw new RuntimeException(classNotFound);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// //
// Copyright 2024 Mirko Raner //
// //
// Licensed under the Apache License, Version 2.0 (the "License"); //
// you may not use this file except in compliance with the License. //
// You may obtain a copy of the License at //
// //
// http://www.apache.org/licenses/LICENSE-2.0 //
// //
// Unless required by applicable law or agreed to in writing, software //
// distributed under the License is distributed on an "AS IS" BASIS, //
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. //
// See the License for the specific language governing permissions and //
// limitations under the License. //
// //
package pro.projo.generation;

import java.util.ArrayList;
import javax.lang.model.type.TypeMirror;
import org.junit.Test;
import net.florianschoppmann.java.reflect.ReflectionTypes;
import pro.projo.template.annotation.Configuration;

public class ProjoTemplateFactoryProcessorTest
{
@Test(expected=RuntimeException.class)
public void testGetConfiguration()
{
ProjoTemplateFactoryProcessor processor = new ProjoTemplateFactoryProcessor();
TypeMirror type = ReflectionTypes.getInstance().typeMirror(ConstructorThrows.class);
processor.getConfiguration(type);
}

@Test(expected=RuntimeException.class)
public void testGetClass()
{
class Nested extends ArrayList<Configuration>
{
private static final long serialVersionUID = 3888598709112160435L;
}
ProjoTemplateFactoryProcessor processor = new ProjoTemplateFactoryProcessor();
TypeMirror type = ReflectionTypes.getInstance().typeMirror(Nested.class);
processor.getClass(type);
}
}

class ConstructorThrows extends ArrayList<Configuration>
{
private static final long serialVersionUID = 4201658057355742410L;

@SuppressWarnings("unused")
public ConstructorThrows()
{
throw new UnsupportedOperationException();
}
}
Loading