Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix an expected result about RemoteTest#test_send #222

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Oct 5, 2024

This PR fixed the following test.

Failure: test_send(RemoteTest)
/home/runner/work/rroonga/rroonga/tmp/test/test-remote.rb:97:in `test_send'
      94:     values = JSON.load(result)
      95:     values.delete("apache_arrow")
      96:     values.delete("features")
  =>  97:     assert_equal([
      98:                    "alloc_count",
      99:                    "cache_hit_rate",
     100:                    "command_version",
<["alloc_count",
 "cache_hit_rate",
 "command_version",
 "default_command_version",
 "max_command_version",
 "memory_map_size",
 "n_jobs",
 "n_queries",
 "start_time",
 "starttime",
 "uptime",
 "version"]> expected but was
<["alloc_count",
 "cache_hit_rate",
 "command_version",
 "default_command_version",
 "default_n_workers",
 "max_command_version",
 "memory_map_size",
 "n_jobs",
 "n_queries",
 "n_workers",
 "start_time",
 "starttime",
 "uptime",
 "version"]>

diff:
  ["alloc_count",
   "cache_hit_rate",
   "command_version",
   "default_command_version",
+  "default_n_workers",
   "max_command_version",
   "memory_map_size",
   "n_jobs",
   "n_queries",
+  "n_workers",
   "start_time",
   "starttime",
   "uptime",
   "version"]

This PR fixed the following test.

```
Failure: test_send(RemoteTest)
/home/runner/work/rroonga/rroonga/tmp/test/test-remote.rb:97:in `test_send'
      94:     values = JSON.load(result)
      95:     values.delete("apache_arrow")
      96:     values.delete("features")
  =>  97:     assert_equal([
      98:                    "alloc_count",
      99:                    "cache_hit_rate",
     100:                    "command_version",
<["alloc_count",
 "cache_hit_rate",
 "command_version",
 "default_command_version",
 "max_command_version",
 "memory_map_size",
 "n_jobs",
 "n_queries",
 "start_time",
 "starttime",
 "uptime",
 "version"]> expected but was
<["alloc_count",
 "cache_hit_rate",
 "command_version",
 "default_command_version",
 "default_n_workers",
 "max_command_version",
 "memory_map_size",
 "n_jobs",
 "n_queries",
 "n_workers",
 "start_time",
 "starttime",
 "uptime",
 "version"]>

diff:
  ["alloc_count",
   "cache_hit_rate",
   "command_version",
   "default_command_version",
+  "default_n_workers",
   "max_command_version",
   "memory_map_size",
   "n_jobs",
   "n_queries",
+  "n_workers",
   "start_time",
   "starttime",
   "uptime",
   "version"]
```
@otegami otegami force-pushed the fix-test-send-in-remote-test branch from 8da81f4 to c0a7784 Compare October 5, 2024 06:33
@kou kou merged commit fdc78f7 into ranguba:master Oct 6, 2024
0 of 18 checks passed
@otegami otegami deleted the fix-test-send-in-remote-test branch October 6, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants