Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix an expected raised error about RemoteTest#test_invalid_select #223

Closed

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Oct 5, 2024

This PR fixed the following error in RemoteTest#test_invalid_select. Because in GQTP protocol, the return code about INVALID_ARGUMENT isn't GRN_INVALID_ARGUMENT(-22) but INVALID_ARGUMENT(65514).

Failure: test_invalid_select(RemoteTest)
/Users/runner/work/rroonga/rroonga/tmp/test/test-remote.rb:117:in `test_invalid_select'
     114:   def test_invalid_select
     115:     context.connect(:host => @host, :port => @port)
     116:
  => 117:     assert_raise(Groonga::InvalidArgument) do
     118:       context.select("bogus", :query => "()()")
     119:     end
     120:   end

<Groonga::InvalidArgument> expected but was
<Groonga::Error(<invalid return code: 65514>)

This PR fixed the following error in RemoteTest#test_invalid_select.
Because in GQTP protocol, the return code about `INVALID_ARGUMENT` isn't
GRN_INVALID_ARGUMENT(-22) but INVALID_ARGUMENT(65514).

```
Failure: test_invalid_select(RemoteTest)
/Users/runner/work/rroonga/rroonga/tmp/test/test-remote.rb:117:in `test_invalid_select'
     114:   def test_invalid_select
     115:     context.connect(:host => @host, :port => @PORT)
     116:
  => 117:     assert_raise(Groonga::InvalidArgument) do
     118:       context.select("bogus", :query => "()()")
     119:     end
     120:   end

<Groonga::InvalidArgument> expected but was
<Groonga::Error(<invalid return code: 65514>)
```
@kou
Copy link
Member

kou commented Oct 6, 2024

The expected value is still valid.
It's a bug of Groonga: groonga/groonga@5c97521

@kou kou closed this Oct 6, 2024
@otegami otegami deleted the fix-test-invalid-select-in-remote-test branch October 6, 2024 07:08
@otegami
Copy link
Contributor Author

otegami commented Oct 6, 2024

Thank you so much for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants