-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerances New PR #161
base: main
Are you sure you want to change the base?
Tolerances New PR #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Also, the non-broken tests for the AVF method passed.
Do you mean that a previously broken test passes now? This is great! Could you please adapt the test accordingly?
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience. We're almost there
Co-authored-by: Hendrik Ranocha <[email protected]>
New PR with tolerances.
Added absolute tolerance for
isapprox()
and exact comparison forRational
inputs.New PR with one test for a RK method with Floating Inputs obtained from MatLab. Also, the non-broken tests for the AVF method passed.