Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for SymPy to 2 for package test, (keep existing compat) #182

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the SymPy package from 1 to 1, 2 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha ranocha closed this Nov 28, 2023
@ranocha ranocha reopened this Nov 28, 2023
@jverzani
Copy link

@ranocha I see two types of errors. One coming from unsatisfiable requirements, the other like

https://github.com/ranocha/BSeries.jl/actions/runs/7016687290/job/19088404156?pr=182#step:7:215

That one is unexpected, as SymPy seems to be not simplifying as it had previously. I tried tracking things down, but didn't see where the issue is to be found. Am I reading this correctly?

@ranocha
Copy link
Owner

ranocha commented Nov 29, 2023

Yes, that's also what I get from it. It seems that it doesn't simplify (1/h) * h == 1 anymore.

@jverzani
Copy link

Yes, it is quite odd. I can't seem to not get the simplification trying combinations of 1/h, inv(h), h^(-1) and various assumptions when I work directly with SymPy. I kept the same recipe for Latexify and it seems to be called when I run within BSeries. If I'm following things correctly -- and that is a shaky assumption -- only the 1/h is being run through latexify in the recipe, and this becomes a string, so no cancellation can occur.

@ranocha
Copy link
Owner

ranocha commented Jun 11, 2024

I needed to update the package extension in #212 to fix the issue: I needed to specialize on Type{SymPy.Sym{SymPy.PyCall.PyObject}} instead of Type{SymPy.Sym} to make it work.

@ranocha ranocha closed this Jun 11, 2024
@ranocha ranocha deleted the compathelper/new_version/2023-11-25-00-14-30-167-01901757421 branch June 11, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants