require new version of FFTW #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Trixi.jl tests fail since an old version of FFTW.jl is used, e.g., version 1.1.1 (from 2019?) instead of a recent version like 1.8, see https://github.com/trixi-framework/Trixi.jl/actions/runs/12877053965/job/35900961134?pr=2243#step:7:151 and trixi-framework/Trixi.jl#2243 This old version of FFTW.jl uses BinaryProvider.jl which is archived and not maintained anymore. Thus, I will update SUmmationByPartsOperators.jl to require newer versions of FFTW.jl that do not use BinaryProvider.jl anymore.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 35 35
Lines 5587 5587
=======================================
Hits 5132 5132
Misses 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Trixi.jl tests fail since an old version of FFTW.jl is used, e.g., version 1.1.1 (from 2019?) instead of a recent version like 1.8, see
https://github.com/trixi-framework/Trixi.jl/actions/runs/12877053965/job/35900961134?pr=2243#step:7:151
and
trixi-framework/Trixi.jl#2243
This old version of FFTW.jl uses BinaryProvider.jl which is archived and not maintained anymore. Thus, I will update SUmmationByPartsOperators.jl to require newer versions of FFTW.jl that do not use BinaryProvider.jl anymore.