Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layouteditor updates #199

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Layouteditor updates #199

wants to merge 5 commits into from

Conversation

raphaelquast
Copy link
Owner

@raphaelquast raphaelquast commented Dec 1, 2023 •
edited
Loading

This PR implements some improvements for the LayoutEditor:

  • add background image capabilities (e.g. show backgrounds during resize/reposition)
  • add option to include map extent in layout editor

@raphaelquast raphaelquast changed the title Layouteditor images Layouteditor updates Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (3313346) 76.71% compared to head (da74de1) 76.73%.

Files Patch % Lines
eomaps/helpers.py 75.96% 25 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
+ Coverage   76.71%   76.73%   +0.02%     
==========================================
  Files          23       23              
  Lines       11155    11227      +72     
==========================================
+ Hits         8557     8615      +58     
- Misses       2598     2612      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphaelquast raphaelquast added this to the EOmaps v7.4 milestone Dec 1, 2023
@raphaelquast raphaelquast force-pushed the layouteditor_images branch 2 times, most recently from 2d892a0 to 6e043ad Compare December 1, 2023 16:02
@raphaelquast raphaelquast modified the milestones: EOmaps v7.4, EOmaps v8.0 Dec 19, 2023
@raphaelquast raphaelquast removed this from the EOmaps v8.0 milestone Jan 30, 2024
@raphaelquast raphaelquast marked this pull request as draft January 30, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raphaelquast