Add base focusable api #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add_base_focusable_api
…e the base behavior is working
Merged
|
After think about the renderer and navigation ecosystem I decided that React Ape will not have any responsibility for the navigation system. I want to leave it open for different types of implementations and solutions. For this reason I'm closing this PR. As far I remember we had discussed about this last year. I decided to follow your thoughts. Thanks for your time @fabiomcosta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this doesn't do much, focusable elements are always
focused...We have to add validation, probably on the renderer level to make sure only one element is focused at a time, and we need to change a navigation-level "currentFocusPath" when
focusedchanges from false to true.Addresses #8