Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian packages: ARM architecture #746

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Debian packages: ARM architecture #746

wants to merge 10 commits into from

Conversation

raphamorim
Copy link
Owner

No description provided.

@raphamorim raphamorim mentioned this pull request Oct 30, 2024
@@ -74,21 +76,28 @@ jobs:
LICENSE

nightly-release-deb:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04-arm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I'd assume cross-compilation would work on ubuntu-latest. Does build fail on it?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, i naively assumed ubuntu had support to arch but doesn't look it does yet

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the builds for linux are stalled on this PR. I'm thinking this may be the cause for it, given ubunt-24.05-arm doesn't seem to be one of GH's default runners -
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking about use something similar to this https://github.com/PMLS3/tauri-linux/blob/1992beef67640f2c843781bbb280f73116ad44c3/flows/arm.yml#L9

Yeah, this should work. I'll try cross-compiling to ARM on an ubuntu box I have around and see what happens. Maybe it's just a matter of ensuring a few deps are installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to build the project, but managed to figure some bits out. There's a dependency that needs the GCC compiler, so the compiler for aarch64 needs to be installed:

sudo apt install g++-aarch64-linux-gnu

Then

export RUSTFLAGS="-C linker=aarch64-linux-gnu-gcc"
cargo build --target aarch64-unknown-linux-gnu

But still fails

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreban if this is something you would like take to help i would glad let you take over 😂🫡

TBH, I likely won't have bandwidth to do it (work trip coming soon)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to build the project, but managed to figure some bits out. There's a dependency that needs the GCC compiler, so the compiler for aarch64 needs to be installed:

I see, I will give another try after finish the split work. I think I got carried over 😆 (i thought i would finish this PR in 10-20min but it looks would need further investigation)

have a good time in your work trip <3

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you ever come to sweden lemme know as well ;)

Copy link
Contributor

@melroy89 melroy89 Nov 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the builds for linux are stalled on this PR. I'm thinking this may be the cause for it, given ubunt-24.05-arm doesn't seem to be one of GH's default runners

Correct, the default GitHub runners doesn't provide an ARM ubuntu specific version. You need to either run & register your own runner (hosted on your own infra), or as proposed above cross-compile to ARM platform using x86. Or use Docker images.

EDIT: Only MacOS arm runners are available apparently: https://github.com/actions/runner-images

strategy:
matrix:
target: [x86_64, aarch64]

steps:
- uses: actions/checkout@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v3
- uses: actions/checkout@v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants