-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noticket snow incident changed update #2719
Open
ewilson-r7
wants to merge
24
commits into
develop
Choose a base branch
from
NOTICKET_SNOW_Incident_Changed_Update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,575
−3,512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <[email protected]> Co-authored-by: Rajat Upadhyaya <[email protected]>
* Upgrade user to root, bump version to 304 * Remove full stop and overlapping link * Restore dockerfile
* SOAR-17026-Bumping requirements of requests * SOAR-17026-Bumping requirements cryptography and idna
…due to empty or wrong typed output fields (#2535)
* Task connection test & SDK Bump * Lint * Adding additional exception handling * Fixing validator * Fixing validator pt2 * SOAR-17320: add html unit tests files * Fixing error * Fixing schema and exception * Changing egress exception handling --------- Co-authored-by: joneill-r7 <[email protected]>
* Powershell | Update SDK * Update help.md
* Add connection test for task * Update test logs and version log * Fix checksum
* Initial commit * Rebase * Rebase * help.md * help.md * Rebase * Refresh
…onary (#2707) * SOAR-17400-return connection test pass a dict * SOAR-17400-Adding a timeout to the connection test requests * SOAR-17400-moving create user to rest api call do products now being a required field * SOAR-17400-moving create user to rest api call do products now being a required field * SOAR-17400-moving create user to rest api call do products now being a required field
* First draft: * Save point * Successful connection test * Fix unit test and add more error handling * Try to patch get current time method * Restore get current time & loop over each api call * Restore unit test imports * Add in cause assist for final exception * Nvm, remove cause and assist * Update error messaging * Updates * Suggested fixes * Loggers everywhere
* Task connection test added & SDK Bump * Changing logging
rbowden-r7
approved these changes
Aug 21, 2024
rbowden-r7
force-pushed
the
develop
branch
2 times, most recently
from
August 28, 2024 09:45
61d2436
to
f5faf31
Compare
rbowden-r7
force-pushed
the
develop
branch
3 times, most recently
from
September 12, 2024 11:03
35a2c1d
to
c63d7dc
Compare
ablakley-r7
force-pushed
the
develop
branch
3 times, most recently
from
September 19, 2024 14:18
409b877
to
7e49c36
Compare
rmurray-r7
force-pushed
the
develop
branch
6 times, most recently
from
November 5, 2024 09:13
e7f10ec
to
2e967fc
Compare
joneill-r7
force-pushed
the
develop
branch
3 times, most recently
from
November 14, 2024 17:00
ba715f2
to
9f862b4
Compare
dlaverty-r7
force-pushed
the
develop
branch
2 times, most recently
from
November 20, 2024 12:01
c2f4dd7
to
6629741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR