Frontend finetuning after v3 graphql #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordythevulder
requested review from
Roene-JustBetter,
royduin and
indykoning
Roene-JustBetter
requested changes
Nov 4, 2024
| @@ -27,5 +26,5 @@ | |||
| @include('rapidez-ct::account.partials.account-features') | |||
| </x-slot:sidebar> | |||
| </x-rapidez-ct::layout> | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
Can you remove the space here?
| @@ -0,0 +1,3 @@ | |||
| <ul {{ $attributes->class('space-y-5 [&>*]:relative [&>*]:pl-7') }}> | |||
There was a problem hiding this comment.
Can you replace [&>*]: this for *:?
indykoning
reviewed
Nov 4, 2024
indykoning
reviewed
Nov 4, 2024
Roene-JustBetter
previously approved these changes
Nov 4, 2024
indykoning
previously approved these changes
Nov 5, 2024
royduin
dismissed stale reviews from indykoning and Roene-JustBetter
The base branch was changed.
|
Conflicts 😇 |
Roene-JustBetter
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.