[3.x] Fix autocomplete & some other reactivesearch errors #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously this worked and the autocomplete file was loaded when clicking in the input. With this it's not lazy loading anymore. What changed? |
I'm not sure, I tried a lot of things but nothing really worked 🙁 bit of a weird frustrating bug. |
|
@indykoning will look into it with RAP-1109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR most importantly fixes the Autocomplete which breaks when used on a fresh page load.
I don't know if this is the solution we really want here... it works, but it's not very nice. It's the same thing that's used in the listing, except it doesn't push into the head because for some reason that didn't work.
Other fixes in this PR include a small error caused by going to a category page without subcategories, and checking if turbo actually exists before trying to load the page size from it.