Bump edition to 2021 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping the edition looks fine to me. Do you have any link about the codegen improvements? |
|
I was mostly referring to https://doc.rust-lang.org/edition-guide/rust-2021/disjoint-capture-in-closures.html |
|
I doubt this is going to change anything for us. Probably still a sensible change. |
|
Probably, it's just nice. No problem getting this change out, I'm now just waiting on darling to publish a new version and this whole thing is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is non-breaking as editions are private, but allows breaking improvements to the language. No changes were required for this crate, but it may improve closure codegen and array iteration.