Enable FutureWarnings/DeprecationWarnings as errors #734
Conversation
| @@ -73,11 +73,12 @@ def svs2tif( | |||
| logger.info(" num_workers: %d", num_workers) | |||
| logger.info(" compression: %s", compression) | |||
| logger.info(" output filename: %s", output_filename) | |||
|
|
|||
| compressionargs = None | |||
There was a problem hiding this comment.
Do we want this to be user facing? Or do we want to keep this internal for now?
There was a problem hiding this comment.
If we make it user facing, we may need to add some additional validation on the input. I would be fine with just keeping it internal for now.
@gigony do you have a preference?
There was a problem hiding this comment.
@grlee77 @jakirkham
It seems appropriate to update it now since this API change has been in effect since July 2022.
https://github.com/cgohlke/tifffile/blame/ec6be6289db1b8b7327bb98816a764c95b9b7299/README.rst#L519
There was a problem hiding this comment.
@grlee77 were there particular thoughts you had on what input validation would look like?
Wonder if tifffile's own validation would work for us
There was a problem hiding this comment.
Let's keep internal for now and merge this change as it is.
| @@ -73,11 +73,12 @@ def svs2tif( | |||
| logger.info(" num_workers: %d", num_workers) | |||
| logger.info(" compression: %s", compression) | |||
| logger.info(" output filename: %s", output_filename) | |||
|
|
|||
| compressionargs = None | |||
There was a problem hiding this comment.
If we make it user facing, we may need to add some additional validation on the input. I would be fine with just keeping it internal for now.
@gigony do you have a preference?
Co-authored-by: Gregory Lee <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
jakirkham
added
improvement
|
/merge |
As part of rapidsai/build-planning#26, enabling Python test failures for
FutureWarnings andDeprecationWarnings