Ensure tests pass

rapidsai · Sep 18, 2024 · 47ce3ce · 47ce3ce
1 parent 25f5a26
commit 47ce3ce
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/python/cudf/cudf/_lib/strings/__init__.py b/python/cudf/cudf/_lib/strings/__init__.py
@@ -73,14 +73,7 @@
 from cudf._lib.strings.find_multiple import find_multiple
 from cudf._lib.strings.findall import findall
 from cudf._lib.strings.json import GetJsonObjectOptions, get_json_object
-from cudf._lib.strings.padding import (
-    SideType,
-    center,
-    ljust,
-    pad,
-    rjust,
-    zfill,
-)
+from cudf._lib.strings.padding import center, ljust, pad, rjust, zfill
 from cudf._lib.strings.repeat import repeat_scalar, repeat_sequence
 from cudf._lib.strings.replace import (
     insert,

diff --git a/python/cudf/cudf/_lib/strings/padding.pyx b/python/cudf/cudf/_lib/strings/padding.pyx
@@ -1,6 +1,8 @@
 # Copyright (c) 2020-2024, NVIDIA CORPORATION.
 from cudf.core.buffer import acquire_spill_lock
 
+from pylibcudf.libcudf.types cimport size_type
+
 from cudf._lib.column cimport Column
 
 import pylibcudf as plc
@@ -20,8 +22,8 @@ def pad(Column source_strings,
     plc_result = plc.strings.padding.pad(
         source_strings.to_pylibcudf(mode="read"),
         width,
+        side,
         fill_char,
-        side
     )
     return Column.from_pylibcudf(plc_result)
 

diff --git a/python/cudf/cudf/_lib/strings/strip.pyx b/python/cudf/cudf/_lib/strings/strip.pyx
@@ -15,7 +15,7 @@ def strip(Column source_strings,
     The set of characters need be stripped from left and right side
     can be specified by `py_repl`.
     """
-    plc_result = plc.string.strip.strip(
+    plc_result = plc.strings.strip.strip(
         source_strings.to_pylibcudf(mode="read"),
         plc.strings.side_type.SideType.BOTH,
         py_repl.device_value.c_value,
@@ -31,7 +31,7 @@ def lstrip(Column source_strings,
     The set of characters need be stripped from left side can
     be specified by `py_repl`.
     """
-    plc_result = plc.string.strip.strip(
+    plc_result = plc.strings.strip.strip(
         source_strings.to_pylibcudf(mode="read"),
         plc.strings.side_type.SideType.LEFT,
         py_repl.device_value.c_value,
@@ -47,7 +47,7 @@ def rstrip(Column source_strings,
     The set of characters need be stripped from right side can
     be specified by `py_repl`.
     """
-    plc_result = plc.string.strip.strip(
+    plc_result = plc.strings.strip.strip(
         source_strings.to_pylibcudf(mode="read"),
         plc.strings.side_type.SideType.RIGHT,
         py_repl.device_value.c_value,