Skip to content

Commit

Permalink
Revert some changes
Browse files Browse the repository at this point in the history
  • Loading branch information
kingcrimsontianyu committed Oct 18, 2024
1 parent 8609304 commit 7f38f82
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions cpp/include/cudf/io/datasource.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,23 +69,17 @@ class datasource {
*/
virtual ~buffer() {}

/**
* @brief Disallow callers to pass an lvalue Container.
*/
template <typename Container>
static std::unique_ptr<buffer> create(Container&) = delete;

/**
* @brief Factory to construct a datasource buffer object from a container.
*
* @tparam Container Type of the container to construct the buffer from
* @param moved_data_owner The container to construct the buffer from (ownership is transferred)
* @param data_owner The container to construct the buffer from (ownership is transferred)
* @return Constructed buffer object
*/
template <typename Container>
static std::unique_ptr<buffer> create(Container&& moved_data_owner)
static std::unique_ptr<buffer> create(Container&& data_owner)
{
return std::make_unique<owning_buffer<Container>>(std::forward<Container>(moved_data_owner));
return std::make_unique<owning_buffer<Container>>(std::forward<Container>(data_owner));
}
};

Expand Down

0 comments on commit 7f38f82

Please sign in to comment.