Skip to content

Commit

Permalink
Revert "Hide all gtest symbols in cudftestutil (#16546)" (#16644)
Browse files Browse the repository at this point in the history
This reverts commit ac42bc8.

We need to revert #16546 as it broke the gtest builds for cudf. Therefore gtests that actually fail wouldn't properly report an error but silently continue and report as passed.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16644
  • Loading branch information
robertmaynard authored Aug 22, 2024
1 parent eaefcb4 commit 83f68c9
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions cpp/cmake/thirdparty/get_gtest.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,9 @@
function(find_and_configure_gtest)
include(${rapids-cmake-dir}/cpm/gtest.cmake)

# Mark all the non explicit googletest symbols as hidden. This ensures that libcudftestutil can be
# used by consumers with a different shared gtest.
set(gtest_hide_internal_symbols ON)

# Find or install GoogleTest
rapids_cpm_gtest(BUILD_STATIC)

# Mark all the explicit googletest symbols as hidden. This ensures that libcudftestutil can be
# used by consumers with a different shared gtest.
if(TARGET gtest)
target_compile_definitions(gtest PUBLIC "$<BUILD_LOCAL_INTERFACE:GTEST_API_=>")
endif()
endfunction()

find_and_configure_gtest()

0 comments on commit 83f68c9

Please sign in to comment.