Skip to content

Commit

Permalink
fix comment typos
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwendt committed Dec 19, 2024
1 parent fb49930 commit b91c9cb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cpp/src/groupby/sort/group_argmax.cu
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ std::unique_ptr<column> group_argmax(column_view const& values,
stream,
mr);

// The functor returns the indices of minimums based on the sorted keys.
// We need the indices of minimums from the original unsorted keys
// The functor returns the indices of maximums based on the sorted keys.
// We need the indices of maximums from the original unsorted keys
// so we use these indices and the key_sort_order to map to the correct indices.
// We do not use cudf::gather since we can move the null-mask separately.
auto indices_view = indices->view();
Expand All @@ -52,7 +52,7 @@ std::unique_ptr<column> group_argmax(column_view const& values,
indices_view.begin<size_type>(), // map first
indices_view.end<size_type>(), // map last
key_sort_order.begin<size_type>(), // input
output.data() // result (most not overlap map)
output.data() // result (must not overlap map)
);
auto null_count = indices_view.null_count();
auto null_mask = indices->release().null_mask.release();
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/groupby/sort/group_argmin.cu
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ std::unique_ptr<column> group_argmin(column_view const& values,
indices_view.begin<size_type>(), // map first
indices_view.end<size_type>(), // map last
key_sort_order.begin<size_type>(), // input
output.data() // result (most not overlap map)
output.data() // result (must not overlap map)
);
auto null_count = indices_view.null_count();
auto null_mask = indices->release().null_mask.release();
Expand Down

0 comments on commit b91c9cb

Please sign in to comment.