-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stream parameter to List Manipulation and Operations APIs #14248
Add stream parameter to List Manipulation and Operations APIs #14248
Conversation
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
Signed-off-by: Suraj Aralihalli <[email protected]>
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will approve once CI tests pass.
@SurajAralihalli Can you please update the PR description to include the bug fix info for concatenate and column_wrapper? Depending on how you see it, changes not included in this PR (e.g., sorting, filtering, etc.) can be deferred to a separate comment.
Signed-off-by: Suraj Aralihalli <[email protected]>
/ok to test |
/merge |
Description
I have organized the public List APIs into three distinct categories based on their functionality, simplifying the PRs for easier and shorter reviews. This particular PR introduces the
stream
parameter only to theList Manipulation and Operations APIs
, which fall underSection 1
. See next comment for other sections.combine.hpp
,contains.hpp
,count_elements.hpp
)This PR addresses issues in the following files:
column_wrapper.hpp:
make_lists_column
function.lists_column_view
.copy_bitmask
withcudf::detail::copy_bitmask
to include the stream parameter.concatenate.cu:
create_null_mask
withcudf::detail::create_null_mask
to include the stream parameter.Reference 13744
Checklist