Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing thread index overflow issue #14290

Merged
merged 4 commits into from
Oct 24, 2023
Merged

fixing thread index overflow issue #14290

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68311b0
fixing thread index overflow issue
hyperbolic2346 Oct 16, 2023
7865ce3
Merge branch 'branch-23.12' into mwilson/thread_overflow
hyperbolic2346 Oct 17, 2023
4de0f41
Merge branch 'branch-23.12' into mwilson/thread_overflow
hyperbolic2346 Oct 18, 2023
e299a35
Merge branch 'branch-23.12' into mwilson/thread_overflow
hyperbolic2346 Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/src/strings/convert/convert_urls.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ __global__ void url_decode_char_counter(column_device_view const in_strings,
char* in_chars_shared = temporary_buffer[local_warp_id];

// Loop through strings, and assign each string to a warp.
for (size_type row_idx = global_warp_id; row_idx < in_strings.size(); row_idx += nwarps) {
for (thread_index_type tidx = global_warp_id; tidx < in_strings.size(); tidx += nwarps) {
auto const row_idx = static_cast<size_type>(tidx);
if (in_strings.is_null(row_idx)) {
out_counts[row_idx] = 0;
continue;
Expand Down Expand Up @@ -296,7 +297,8 @@ __global__ void url_decode_char_replacer(column_device_view const in_strings,
char* in_chars_shared = temporary_buffer[local_warp_id];

// Loop through strings, and assign each string to a warp
for (size_type row_idx = global_warp_id; row_idx < in_strings.size(); row_idx += nwarps) {
for (thread_index_type tidx = global_warp_id; tidx < in_strings.size(); tidx += nwarps) {
auto const row_idx = static_cast<size_type>(tidx);
if (in_strings.is_null(row_idx)) continue;

auto const in_string = in_strings.element<string_view>(row_idx);
Expand Down