Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy JSON reader and concurrent_unordered_map.cuh. #15813

Merged
merged 3 commits into from
May 23, 2024
Merged

Remove legacy JSON reader and concurrent_unordered_map.cuh. #15813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75cd6f7
Remove legacy JSON reader.
bdice May 22, 2024
ba8fca3
Remove concurrent_unordered_map.cuh.
bdice May 22, 2024
b83b099
Remove legacy argument.
bdice May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,6 @@ add_library(
src/io/json/json_tree.cu
src/io/json/nested_json_gpu.cu
src/io/json/read_json.cu
src/io/json/legacy/json_gpu.cu
src/io/json/legacy/reader_impl.cu
src/io/json/parser_features.cpp
src/io/json/write_json.cu
src/io/orc/aggregate_orc_metadata.cpp
Expand Down
32 changes: 0 additions & 32 deletions cpp/include/cudf/io/json.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,6 @@ class json_reader_options {
*/
bool is_enabled_dayfirst() const { return _dayfirst; }

/**
* @brief Whether the legacy reader should be used.
*
* @deprecated Since 24.06
*
* @returns true if the legacy reader will be used, false otherwise
*/
[[deprecated]] bool is_enabled_legacy() const { return _legacy; }

/**
* @brief Whether the reader should keep quotes of string values.
*
Expand Down Expand Up @@ -406,15 +397,6 @@ class json_reader_options {
*/
void enable_dayfirst(bool val) { _dayfirst = val; }

/**
* @brief Set whether to use the legacy reader.
*
* @deprecated Since 24.06
*
* @param val Boolean value to enable/disable the legacy reader
*/
[[deprecated]] void enable_legacy(bool val) { _legacy = val; }

/**
* @brief Set whether the reader should keep quotes of string values.
*
Expand Down Expand Up @@ -605,20 +587,6 @@ class json_reader_options_builder {
return *this;
}

/**
* @brief Set whether to use the legacy reader.
*
* @deprecated Since 24.06
*
* @param val Boolean value to enable/disable legacy parsing
* @return this for chaining
*/
[[deprecated]] json_reader_options_builder& legacy(bool val)
{
options._legacy = val;
return *this;
}

/**
* @brief Set whether the reader should keep quotes of string values.
*
Expand Down
1 change: 0 additions & 1 deletion cpp/src/groupby/hash/groupby.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

#include "groupby/common/utils.hpp"
#include "groupby/hash/groupby_kernels.cuh"
#include "hash/concurrent_unordered_map.cuh"

#include <cudf/aggregation.hpp>
#include <cudf/column/column.hpp>
Expand Down
Loading
Loading