Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor mixed_semi_join using cuco::static_set #16230
Refactor mixed_semi_join using cuco::static_set #16230
Changes from all commits
caea465
913aed7
be82efb
a8922c5
dc7b7d1
5cc0c62
6f73ed8
08ad9cb
1e7054d
c9f3e29
cd18674
bd2d930
c7f960e
b62a786
8b10e65
d49131d
b8bf218
51021ae
c83e4a6
b5e8c79
f6d8a8a
8359ec7
8e9ab66
18d652f
e458d39
ee0e606
ce2cb57
47c0938
08410dd
bdc13e2
d860e86
964bf6a
1ba2bad
7b640d6
0e88b41
9189c2c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for this order change build and probe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to dig into why but without this change the gtests start failing. Maybe @srinivasyadav18 can provide us a quick insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: We changed this order and added
swap_tables=true
at mixed_join_kernels_semi.cu:+72 (tagged you there) to fix the left and right directionality in the equality insingle_expression_equality::operator()
. Specifically, thesingle_expression_equality
expects indices in{build, probe}
order and we have also reset the hasher and equality functors for thecuco::static_set
which swaps the internalleft
andright
directions for{build, probe}
hence us usingswap_table=true
.I know it's quite confusing. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mainly due to a breaking change in NVIDIA/cuCollections#479 where we always put query keys on the left-hand side for comparison.