do not install cudf in cudf_polars wheel tests #16612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary installation of
cudf
wheels in wheel testing forcudf_polars
.cudf_polars
doesn't depend oncudf
, and neither do its tests. However, right now it's downloadingcudf
during it's wheel tests. I mistakenly introduced that in #16575.This introduced a race condition that could lead to CI failures whenever the
cudf
wheels aren't published yet by the time thecudf_polars
tests. Because thecudf_polars
wheel tests (rightly) do not wait forcudf
wheels to be available:cudf/.github/workflows/pr.yaml
Lines 154 to 155 in 555734d
cudf/.github/workflows/pr.yaml
Lines 145 to 146 in 555734d
Noticed this in #16611
(build link)
Checklist