Fix interval_range right child non-zero offset #16651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
xref #16507
Similar to what is done in
IntervalIndex.from_breaks
,interval_index
generates the right edges by slicing a range of fencepost edges. However, we don't want to maintain the newoffset
(1
) on the right edge after slicing as it adversely impacts subsequent indexing operations.Additionally, I noticed thatIndex(struct_data)
would automatically convert it to anIntervalIndex
, butIntervalIndex
has a strict requirement on the data haveleft/right
keys, so making this raise aNotImplementedError
instead^ Will tackle this in a follow up, looks like there are cases where this is valid
Checklist