Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interval_range right child non-zero offset #16651

Merged

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Aug 23, 2024

Description

xref #16507

Similar to what is done in IntervalIndex.from_breaks, interval_index generates the right edges by slicing a range of fencepost edges. However, we don't want to maintain the new offset (1) on the right edge after slicing as it adversely impacts subsequent indexing operations.

Additionally, I noticed that Index(struct_data) would automatically convert it to an IntervalIndex, but IntervalIndex has a strict requirement on the data have left/right keys, so making this raise a NotImplementedError instead
^ Will tackle this in a follow up, looks like there are cases where this is valid

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Aug 23, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 23, 2024 20:12
@mroeschke mroeschke requested review from isVoid and lithomas1 August 23, 2024 20:12
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 88de8dd into rapidsai:branch-24.10 Aug 27, 2024
87 checks passed
@mroeschke mroeschke deleted the bug/interval_range/right_offset branch August 27, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants