Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loc/iloc.__setitem__[:, loc] with non cupy types #16677

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Discovered in #16652, DataFrame.iloc/loc.__setitem__ with a non-cupy type e.g. "category" failed because the indexing path unconditionally tries to cupy.asarray the value to be set which only accepts types recognized by cupy.

We can skip this asarray if we have a numpy/pandas/cudf object

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Aug 28, 2024
@mroeschke mroeschke requested a review from a team as a code owner August 28, 2024 01:41
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 1a96e4c into rapidsai:branch-24.10 Aug 28, 2024
82 checks passed
@mroeschke mroeschke deleted the bug/setitem/cudf_types branch August 28, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants