-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize parquet reader mukernel non-nullable code, introduce manual block scans #16830
Merged
rapids-bot
merged 20 commits into
rapidsai:branch-24.12
from
pmattione-nvidia:mukernels_fixedwidth_optimize
Oct 11, 2024
Merged
Organize parquet reader mukernel non-nullable code, introduce manual block scans #16830
rapids-bot
merged 20 commits into
rapidsai:branch-24.12
from
pmattione-nvidia:mukernels_fixedwidth_optimize
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable column code
pmattione-nvidia
added
libcudf
Affects libcudf (C++/CUDA) code.
Performance
Performance related issue
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Sep 18, 2024
pmattione-nvidia
requested review from
karthikeyann,
kingcrimsontianyu and
nvdbaranec
September 24, 2024 18:44
nvdbaranec
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. Will absorb and come back for another.
Co-authored-by: nvdbaranec <[email protected]>
Co-authored-by: nvdbaranec <[email protected]>
Co-authored-by: nvdbaranec <[email protected]>
…attione-nvidia/cudf into mukernels_fixedwidth_optimize
vuule
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice set of changes!
Co-authored-by: Vukasin Milovanovic <[email protected]>
…attione-nvidia/cudf into mukernels_fixedwidth_optimize
pmattione-nvidia
changed the title
Optimize parquet reader mukernel block scans, non-nullable code
Organize parquet reader mukernel non-nullable code, introduce manual block scans
Oct 4, 2024
nvdbaranec
approved these changes
Oct 10, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Performance
Performance related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of a few small optimizations and tweaks for the parquet reader fixed-width mukernels (flat & nested, lists not implemented yet). The benchmark changes are negligible, this is mainly cleanup and code in preparation for the upcoming list mukernel.
If not reading the whole page (chunked reads) exit sooner
By having each thread keep track of the current valid_count (and not saving-to or reading-from the nesting_info until the end), we don't need to synchronize the block threads as frequently, so these extra syncs are removed.
For (non-list) nested columns that aren't nullable, we don't need to loop over the whole nesting depth; only the last level of nesting is used. After removing this loop, the non-nullable code for nested and flat hierarchies is identical, so they're extracted and consolidated into a new function.
When doing block scans in the parquet reader we also need to know the per-warp results of the scan. Because cub doesn't return those, we then do an additional warp-wide ballot that is unnecessary. This introduces code that does a block scan manually, saving the intermediate results. However using this code in the flat & nested kernels uses 8 more registers, so it isn't used yet.
By doing an exclusive-scan instead of an inclusive-scan, we don't need the extra "- 1's" that were everywhere.
Checklist