Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance regression for generate_character_ngrams #16849

Merged
merged 11 commits into from
Oct 3, 2024
Merged

Fix performance regression for generate_character_ngrams #16849

merged 11 commits into from
Oct 3, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes performance regression in nvtext::generate_character_ngrams introduced in #16212. Thread-per-row kernel is faster for smaller strings.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Sep 19, 2024
@davidwendt davidwendt self-assigned this Sep 19, 2024
@davidwendt davidwendt changed the base branch from branch-24.10 to branch-24.12 September 23, 2024 23:22
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 26, 2024
@davidwendt davidwendt marked this pull request as ready for review September 26, 2024 14:19
@davidwendt davidwendt requested a review from a team as a code owner September 26, 2024 14:19
vuule
vuule approved these changes Sep 30, 2024
View reviewed changes
cpp/src/text/generate_ngrams.cu Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 466e379 into rapidsai:branch-24.12 Oct 3, 2024
100 checks passed
@davidwendt davidwendt deleted the char-ngram-perf branch October 3, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @bdice @ttnghia @vuule @galipremsagar