Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pandas pinnings to support 2.2.3 #16882

Merged
merged 29 commits into from
Oct 4, 2024
Merged

Upgrade pandas pinnings to support 2.2.3 #16882

merged 29 commits into from
Oct 4, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Pandas released a newer version 2.2.3 with very minimal fixes but one that adds support for python-3.13 and numpy 2.1 compatibility. This PR updates pinnings in cudf to support 2.2.3.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 23, 2024
@galipremsagar galipremsagar self-assigned this Sep 23, 2024
@galipremsagar galipremsagar requested review from a team as code owners September 23, 2024 23:51
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 23, 2024
@galipremsagar galipremsagar changed the base branch from branch-24.10 to branch-24.12 September 24, 2024 18:03
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 26, 2024
@vyasr
Copy link
Contributor

vyasr commented Sep 27, 2024

@galipremsagar there seems to be a consistent failure of the CUDA 12.01 Python 3.11 job. I doubt the CUDA version has anything to do with it, but Python 3.11 seems like a much more likely culprit. Could you take a look?

@galipremsagar
Copy link
Contributor Author

@galipremsagar there seems to be a consistent failure of the CUDA 12.01 Python 3.11 job. I doubt the CUDA version has anything to do with it, but Python 3.11 seems like a much more likely culprit. Could you take a look?

Yup

@galipremsagar galipremsagar requested a review from a team as a code owner October 2, 2024 17:48
@galipremsagar galipremsagar requested a review from bdice October 2, 2024 17:48
@galipremsagar galipremsagar marked this pull request as draft October 2, 2024 17:49
@galipremsagar galipremsagar marked this pull request as ready for review October 4, 2024 17:42
vyasr
vyasr approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for sorting out the arm solver issue!

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c958d8e into rapidsai:branch-24.12 Oct 4, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@vyasr vyasr vyasr approved these changes

@wence- wence- wence- approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @vyasr @wence- @jameslamb