[NOT READY FOR MERGE] Fix the issue where cmake/ctest finds 0 test despite test binaries having been properly built #17136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving been properly built
github-actions
bot
added
libcudf
kingcrimsontianyu
added
non-breaking
|
The problem arises from curl: curl/curl#15351 . @robertmaynard will put the fix into kvikIO, which is the direct user of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following command shows that cmake/ctest finds 0 test (although all the test binaries have been properly built and can be individually run in the
/home/coder/cudf/cpp/build/latest/gtestsdirectory).The reason is that the subproject KvikIO sets the cmake cache variable
BUILD_TESTINGtoOFFand propagates it to cuDF project. This PR provides a fix.Checklist