Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore loud dask warnings about legacy dataframe implementation #17137

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Ignore loud dask warnings about legacy dataframe implementation #17137

merged 2 commits into from
Oct 21, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

This PR ignores loud dask warnings about legacy dask dataframe implementation is going to be soon removed: dask/dask#11437

Note: We only see this error for DASK_DATAFRAME__QUERY_PLANNING=False cases, DASK_DATAFRAME__QUERY_PLANNING=True are passing fine.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Oct 21, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner October 21, 2024 18:36
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 21, 2024
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Oct 21, 2024
bdice
bdice approved these changes Oct 21, 2024
View reviewed changes
python/dask_cudf/pyproject.toml Outdated Show resolved Hide resolved
python/dask_cudf/pyproject.toml Outdated Show resolved Hide resolved
pentschev
pentschev approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar .

rjzamora
rjzamora approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galipremsagar ! I second the suggestions from @bdice, but otherwise approve.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Oct 21, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 69ca387 into rapidsai:branch-24.12 Oct 21, 2024
98 checks passed
@jameslamb jameslamb mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

@pentschev pentschev pentschev approved these changes

@bdice bdice bdice approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @bdice @pentschev @rjzamora