Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Nullify non-struct rows in JSONL inputs #17178

Closed
wants to merge 1 commit into from
Closed

[WIP] Nullify non-struct rows in JSONL inputs #17178

wants to merge 1 commit into from

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Oct 25, 2024

Description

TBA.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 25, 2024
@shrshi shrshi added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Oct 25, 2024
@shrshi shrshi mentioned this pull request Oct 25, 2024
Closed
3 tasks
@karthikeyann
Copy link
Contributor

@shrshi spark need the non-struct rows information to set top level struct as nulls.

@shrshi
Copy link
Contributor Author

shrshi commented Oct 28, 2024

Closed since the performance improvement of cub::BatchedMemcpy over join_strings in #17028 is not significant. This renders this blocking bug fix PR unnecessary.

@shrshi shrshi closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrshi @karthikeyann