Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cudf.isclose #17351

Closed
Changes from 1 commit
Commits
Show all changes
195 commits
Select commit Hold shift + click to select a range
8664fad
add telemetry setup to test (#16924)
msarahan Nov 15, 2024
e683647
Update cmake to 3.28.6 in JNI Dockerfile (#17342)
jlowe Nov 15, 2024
9cc9071
Use pylibcudf contiguous split APIs in cudf python (#17246)
Matt711 Nov 16, 2024
c418cb2
First Commit isclose depreciation
enoch-gives-thanks Nov 17, 2024
e4de8e4
Move strings translate benchmarks to nvbench (#17325)
davidwendt Nov 18, 2024
aeb6a30
Move cudf._lib.unary to cudf.core._internals (#17318)
mroeschke Nov 18, 2024
03ac845
Reading multi-source compressed JSONL files (#17161)
shrshi Nov 18, 2024
d514517
Test the full matrix for polars and dask wheels on nightlies (#17320)
vyasr Nov 18, 2024
43f2f68
Fix reading Parquet string cols when `nrows` and `input_pass_limit` >…
mhaseeb123 Nov 18, 2024
18b40dc
Remove cudf._lib.hash in favor of inlining pylibcudf (#17345)
mroeschke Nov 18, 2024
ba21673
Remove cudf._lib.concat in favor of inlining pylibcudf (#17344)
mroeschke Nov 18, 2024
02c35bf
Remove cudf._lib.quantiles in favor of inlining pylibcudf (#17347)
mroeschke Nov 18, 2024
302e625
Remove cudf._lib.labeling in favor of inlining pylibcudf (#17346)
mroeschke Nov 18, 2024
5f9a97f
Support polars 1.14 (#17355)
wence- Nov 19, 2024
384abae
Writing compressed output using JSON writer (#17323)
shrshi Nov 19, 2024
9c5cd81
fix library-loading issues in editable installs (#17338)
jameslamb Nov 19, 2024
c7bfa77
Fix integer overflow in compiled binaryop (#17354)
wence- Nov 19, 2024
03c055f
Move strings replace benchmarks to nvbench (#17301)
davidwendt Nov 19, 2024
56061bd
Optimize distinct inner join to use set `find` instead of `retrieve` …
PointKernel Nov 19, 2024
7158ee0
Add compute_column_expression to pylibcudf for transform.compute_colu…
mroeschke Nov 20, 2024
05365af
Bug fix: restrict lines=True to JSON format in Kafka read_gdf method …
a-hirota Nov 20, 2024
6f83b58
Adapt to KvikIO API change in the compatibility mode (#17377)
kingcrimsontianyu Nov 20, 2024
fc08fe8
Benchmarking JSON reader for compressed inputs (#17219)
shrshi Nov 20, 2024
a2a62a1
Deselect failing polars tests (#17362)
pentschev Nov 20, 2024
3111aa4
Add new ``dask_cudf.read_parquet`` API (#17250)
rjzamora Nov 20, 2024
698a716
Merge branch-24.12 into branch-25.02
bdice Nov 20, 2024
664fd87
Merge pull request #17379 from bdice/branch-25.02-merge-24.12
raydouglass Nov 20, 2024
be9ba6c
Added Arrow Interop Benchmarks (#17194)
lamarrr Nov 20, 2024
d01f332
Merge pull request #17380 from rapidsai/branch-24.12
GPUtester Nov 20, 2024
2e88835
Use `libcudf_exception_handler` throughout `pylibcudf.libcudf` (#17109)
brandon-b-miller Nov 20, 2024
110ed4c
Merge pull request #17382 from rapidsai/branch-24.12
GPUtester Nov 20, 2024
f550ccc
Extract ``GPUEngine`` config options at translation time (#17339)
rjzamora Nov 20, 2024
2cde861
Merge pull request #17383 from rapidsai/branch-24.12
GPUtester Nov 20, 2024
04502c8
Move strings url_decode benchmarks to nvbench (#17328)
davidwendt Nov 20, 2024
f87f017
Merge pull request #17384 from rapidsai/branch-24.12
GPUtester Nov 20, 2024
332cc06
Support pivot with index or column arguments as lists (#17373)
mroeschke Nov 20, 2024
cd0c0d0
Merge pull request #17385 from rapidsai/branch-24.12
GPUtester Nov 20, 2024
d927992
Move strings repeat benchmarks to nvbench (#17304)
davidwendt Nov 20, 2024
e52df19
Merge pull request #17391 from rapidsai/branch-24.12
GPUtester Nov 20, 2024
68c4285
Add `pynvml` as a dependency for `dask-cudf` (#17386)
pentschev Nov 21, 2024
0d9e577
Ignore errors when testing glibc versions (#17389)
vyasr Nov 21, 2024
c46e9e4
Merge branch-24.12 into branch-25.02
jakirkham Nov 21, 2024
1bfc114
Merge pull request #17395 from jakirkham/branch-25.02-merge-24.12
raydouglass Nov 21, 2024
f54c1a5
Migrate CSV writer to pylibcudf (#17163)
Matt711 Nov 21, 2024
ffeea05
Merge pull request #17401 from rapidsai/branch-24.12
GPUtester Nov 21, 2024
78db66b
Expose stream-ordering to interop APIs (#17397)
shrshi Nov 21, 2024
b2419dd
Document interpreter install command for cudf.pandas (#17358)
bdice Nov 21, 2024
305182e
Enable unified memory by default in `cudf_polars` (#17375)
galipremsagar Nov 22, 2024
2827a03
Merge pull request #17417 from rapidsai/branch-24.12
GPUtester Nov 22, 2024
53e4525
Add write_parquet to pylibcudf (#17263)
mroeschke Nov 22, 2024
5a89d00
Run clang-tidy checks in PR CI (#17407)
bdice Nov 22, 2024
881afd1
Remove cudf._lib.transpose in favor of inlining pylibcudf (#17365)
mroeschke Nov 22, 2024
092fdff
Update xxhash_64 to utilize the cuco equivalent implementation (#17393)
PointKernel Nov 22, 2024
8b7127f
Fix Debug-mode failing Arrow test (#17405)
zeroshade Nov 22, 2024
d1d4420
Move cudf._lib.search to cudf.core._internals (#17411)
mroeschke Nov 23, 2024
44b2e79
Remove the unused detail `int_fastdiv.h` header (#17426)
PointKernel Nov 24, 2024
8d8cd78
Expose stream-ordering to groupby APIs (#17324)
shrshi Nov 25, 2024
d93e9c2
Expose stream-ordering to strings attribute APIs (#17398)
shrshi Nov 25, 2024
f05e89d
Single-partition Dask executor for cuDF-Polars (#17262)
rjzamora Nov 25, 2024
4e3afd2
Change binops for-each kernel to thrust::for_each_n (#17419)
davidwendt Nov 26, 2024
ccc8833
Remove cudf._lib.timezone in favor of inlining pylibcudf (#17366)
mroeschke Nov 26, 2024
df17740
Remove cudf._lib.partitioning in favor of inlining pylibcudf (#17369)
mroeschke Nov 26, 2024
d8277bf
Remove cudf._lib.lists in favor of inlining pylibcudf (#17425)
mroeschke Nov 26, 2024
0bd95c9
Remove cudf._lib.rolling in favor of inlining pylibcudf (#17423)
mroeschke Nov 26, 2024
ab36fc6
Return categorical values in to_numpy/to_cupy (#17388)
mroeschke Nov 26, 2024
79a9860
Remove cudf._lib.reshape in favor of inlining pylibcudf (#17368)
mroeschke Nov 26, 2024
d10eae7
Update strings/text source to use grid_1d for thread/block/stride cal…
davidwendt Nov 26, 2024
e7022fb
Use thread_index_type in binary-ops jit kernel.cu (#17420)
davidwendt Nov 26, 2024
f5954a4
Remove nvtx/ranges.hpp include from cuda.cuh (#17427)
davidwendt Nov 26, 2024
b89728b
Abstract polars function expression nodes to ensure they are serializ…
pentschev Nov 26, 2024
165d756
Migrate ORC Writer to pylibcudf (#17310)
Matt711 Nov 26, 2024
776ef54
Remove cudf._lib.join in favor of inlining pylibcudf (#17371)
mroeschke Nov 26, 2024
d714173
Remove unused type aliases (#17396)
PointKernel Nov 26, 2024
fa62ff4
Add breaking change workflow trigger (#17248)
AyodeAwe Nov 26, 2024
797a07b
Require approval to run CI on draft PRs (#17450)
bdice Nov 26, 2024
4533085
Add CSV Reader options classes to pylibcudf (#17412)
Matt711 Nov 27, 2024
6e91f09
Remove cudf._lib.null_mask in favor of inlining pylibcudf (#17440)
mroeschke Nov 27, 2024
6eaa65f
Remove some cudf._lib.strings files in favor of inlining pylibcudf (#…
mroeschke Nov 27, 2024
6d8ec80
Remove cudf._lib.quantile (#17424)
mroeschke Nov 27, 2024
83f0ae0
Fix write_json failure for zero columns in table/struct (#17414)
karthikeyann Nov 27, 2024
0495071
Adapt to rmm logger changes (#17451)
vyasr Nov 27, 2024
3133b5a
Update Hadoop dependency in Java pom (#17454)
jlowe Nov 27, 2024
adaee75
Set build type for all examples (#17463)
vyasr Nov 27, 2024
9db132a
Update MurmurHash3_x86_32 to use the cuco equivalent implementation (…
PointKernel Nov 27, 2024
2c89dba
Support dask>=2024.11.2 in Dask cuDF (#17439)
rjzamora Nov 27, 2024
2be82fe
Clean up xxhash_64 implementations (#17455)
PointKernel Nov 28, 2024
9b88794
Remove cudf._lib.json in favor of inlining pylibcudf (#17443)
mroeschke Nov 28, 2024
891a865
Add support for `pylibcudf.DataType` serialization (#17352)
pentschev Nov 28, 2024
b084d74
Remove cudf._lib.datetime in favor of inlining pylibcudf (#17372)
mroeschke Nov 28, 2024
4de7e7a
Expose stream-ordering in replace API (#17436)
shrshi Dec 1, 2024
4b2dc33
skip most CI on devcontainer-only changes (#17465)
jameslamb Dec 2, 2024
3e418dd
Move make_strings_column benchmark to nvbench (#17340)
davidwendt Dec 2, 2024
5190b44
Temporarily skip tests due to dask/distributed#8953 (#17472)
wence- Dec 2, 2024
6884867
Remove cudf._lib.replace in favor of inlining pylibcudf (#17428)
mroeschke Dec 2, 2024
d1bad33
Update the hook versions in pre-commit (#17462)
wence- Dec 2, 2024
852338e
Update PyTorch to >=2.4.0 to get fix for CUDA array interface bug, an…
bdice Dec 2, 2024
da72cf6
Remove cudf._lib.filling in favor of inlining pylibcudf (#17459)
mroeschke Dec 2, 2024
b67c0a9
Update MurmurHash3_x64_128 to use the cuco equivalent implementation …
PointKernel Dec 3, 2024
12c77f3
add comment to Series.tolist method (#17350)
tequilayu Dec 3, 2024
3785a48
Add multi-partition `DataFrameScan` support to cuDF-Polars (#17441)
rjzamora Dec 3, 2024
4696bbf
Revert "Temporarily skip tests due to dask/distributed#8953" (#17492)
Matt711 Dec 3, 2024
d3e94d4
Apply clang-tidy autofixes from new rules (#17431)
vyasr Dec 3, 2024
beb4296
Workaround for a misaligned access in `read_csv` on some CUDA version…
vuule Dec 3, 2024
7cc9a9f
Use exec_policy_nosync in write_json (#17445)
karthikeyann Dec 3, 2024
541e7e8
Make `column_empty` mask buffer creation consistent with libcudf (#16…
mroeschke Dec 3, 2024
1b01df3
Use grid_1d utilities in copy_range.cuh (#17409)
davidwendt Dec 4, 2024
439321e
Turn off cudf.pandas 3rd party integrations tests for 24.12 (#17500)
Matt711 Dec 4, 2024
86d833b
Change indices for dictionary column to signed integer type (#17390)
davidwendt Dec 4, 2024
de1f809
Merge branch-24.12 into branch-25.02
Matt711 Dec 4, 2024
3ca188d
Merge pull request #17511 from Matt711/branch-25.02-merge-24.12
AyodeAwe Dec 4, 2024
6440207
Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 (#17326)
bdice Dec 4, 2024
38820ff
Update to CCCL 2.7.0-rc2. (#17233)
bdice Dec 4, 2024
43fac3b
Expose stream-ordering in nvtext API (#17446)
shrshi Dec 4, 2024
4505c53
Return empty result for segmented_reduce if input and offsets are bot…
davidwendt Dec 4, 2024
351ece5
Remove cudf._lib.binops in favor of inlining pylibcudf (#17468)
mroeschke Dec 4, 2024
cd3e352
Migrate `cudf::io::merge_row_group_metadata` to pylibcudf (#17491)
Matt711 Dec 4, 2024
47e49d0
Fix groupby(as_index=False).size not reseting index (#17499)
mroeschke Dec 4, 2024
1b82963
Fix libcudf compile error when logging is disabled (#17512)
davidwendt Dec 4, 2024
fbc3256
Force Thrust to use 32-bit offset type. (#17523)
bdice Dec 5, 2024
06e937b
Remove cudf._lib.merge in favor of inlining pylibcudf (#17370)
mroeschke Dec 5, 2024
c0a4c6c
Move cudf._lib.aggregation to cudf.core._internals (#17516)
mroeschke Dec 6, 2024
84690b5
Migrate copy_column and Column.from_scalar to pylibcudf (#17513)
Matt711 Dec 6, 2024
169a45a
Plumb pylibcudf.io.parquet options classes through cudf python (#17506)
Matt711 Dec 6, 2024
38261f8
Improve strings contains/find performance for smaller strings (#17330)
davidwendt Dec 6, 2024
c791f80
Remove cudf._lib.text in favor of inlining pylibcudf (#17408)
mroeschke Dec 6, 2024
467cf7a
Replaces uses of `cudf._lib.Column.from_unique_ptr` with `pylibcudf.C…
Matt711 Dec 6, 2024
1a62b46
Remove cudf._lib.round in favor of inlining pylibcudf (#17430)
mroeschke Dec 6, 2024
b6f7e6e
Remove cudf._lib.orc in favor of inlining pylibcudf (#17466)
mroeschke Dec 6, 2024
cbeefd8
Add Parquet Reader options classes to pylibcudf (#17464)
Matt711 Dec 6, 2024
14b4321
Fix all null list column with missing child column in JSON reader (#1…
karthikeyann Dec 6, 2024
80fc629
Update cuda-python lower bounds to 12.6.2 / 11.8.5 (#17547)
bdice Dec 7, 2024
a0fc6a8
Use cooperative-groups instead of cub warp-reduce for strings contain…
davidwendt Dec 9, 2024
0f5d4b9
Remove unused IO utilities from cudf python (#17374)
Matt711 Dec 9, 2024
ba3ed57
Fix nvcc-imposed UB in `constexpr` functions (#17534)
vuule Dec 9, 2024
ed2892c
Document undefined behavior in div_rounding_up_safe (#17542)
davidwendt Dec 9, 2024
a79077c
[JNI] Enables fabric handles for CUDA async memory pools (#17526)
abellina Dec 9, 2024
f595592
Remove cudf._lib.string.convert/split in favor of inlining pylibcudf …
mroeschke Dec 9, 2024
5b412dc
[JNI] remove rmm argument to set rw access for fabric handles (#17553)
abellina Dec 9, 2024
9df95d1
Remove cudf._lib.transform in favor of inlining pylibcudf (#17505)
mroeschke Dec 9, 2024
ebad043
Remove unused `BufferArrayFromVector` (#17549)
Matt711 Dec 9, 2024
4764395
Enable rounding for Decimal32 and Decimal64 in cuDF (#17332)
a-hirota Dec 10, 2024
c53ace8
Fix CMake format in cudf/_lib/CMakeLists.txt (#17559)
mroeschke Dec 10, 2024
e16b3a3
Remove Thrust patch in favor of CMake definition for Thrust 32-bit of…
bdice Dec 10, 2024
13e983e
gate telemetry dispatch calls on TELEMETRY_ENABLED env var (#17551)
msarahan Dec 10, 2024
3468e92
Replace cudf::detail::copy_if logic with thrust::copy_if and gather (…
davidwendt Dec 10, 2024
2f5bf76
Simplify serialization protocols (#17552)
vyasr Dec 10, 2024
5306eca
Use rapids-logger to generate the cudf logger (#17307)
vyasr Dec 10, 2024
657f50b
Fix typos, rename types, and add null_probability benchmark axis for …
PointKernel Dec 10, 2024
f904a7f
Merge branch-24.12 into branch-25.02
Matt711 Dec 10, 2024
be62ea6
Update version references in workflow (#17568)
AyodeAwe Dec 10, 2024
1e95864
Fix Dask-cuDF `clip` APIs (#17509)
rjzamora Dec 10, 2024
0c5bd66
Rework minhash APIs for deprecation cycle (#17421)
davidwendt Dec 10, 2024
cd3a79b
Specify a version for rapids_logger dependency (#17573)
jlowe Dec 11, 2024
3801e74
Replace direct `cudaMemcpyAsync` calls with utility functions (within…
vuule Dec 11, 2024
63c5a38
Fix some possible thread-id overflow calculations (#17473)
davidwendt Dec 11, 2024
ebe5bad
Merge pull request #17569 from Matt711/branch-25.02-merge-24.12
raydouglass Dec 11, 2024
32548b0
Expose Scalar's constructor and `Scalar#getScalarHandle()` to public …
ttnghia Dec 12, 2024
78e5c0d
Use batched memcpy when writing ORC statistics (#17572)
vuule Dec 12, 2024
00ed1f2
Remove unused code of json schema in JSON reader (#17581)
karthikeyann Dec 12, 2024
98d9856
Add anonymous namespace to libcudf test source (#17529)
davidwendt Dec 12, 2024
92652be
Remove cudf._lib.parquet in favor of inlining pylibcudf (#17562)
mroeschke Dec 12, 2024
f811c38
Allow large strings in nvbench strings benchmarks (#17571)
davidwendt Dec 12, 2024
8a3e5f1
Remove cudf._lib.nvtext in favor of inlining pylibcudf (#17535)
mroeschke Dec 13, 2024
7749702
Remove cudf._lib.csv in favor in inlining pylibcudf (#17485)
mroeschke Dec 13, 2024
5baaf6d
Propagate failures in pandas integration tests and Skip failing tests…
Matt711 Dec 13, 2024
48aa08f
Remove cudf._lib.reduce in favor of inlining pylibcudf (#17574)
mroeschke Dec 13, 2024
f3f159a
Use no-sync copy for fixed-width types in cudf::concatenate (#17584)
davidwendt Dec 13, 2024
a095727
Allow large strings in nvtext benchmarks (#17579)
davidwendt Dec 13, 2024
62669e0
Fix ctest fail running libcudf tests in a Debug build (#17576)
davidwendt Dec 13, 2024
4d6925c
Remove unused masked keyword in column_empty (#17530)
mroeschke Dec 13, 2024
1a67646
Move cudf._lib.sort to cudf.core._internals (#17488)
mroeschke Dec 13, 2024
34e2045
Mark more constexpr functions as device-available (#17545)
vyasr Dec 13, 2024
76b35ad
Ignore NaN correctly in .quantile (#17593)
mroeschke Dec 13, 2024
e9744b4
Enable all json reader options in pylibcudf read_json (#17563)
karthikeyann Dec 16, 2024
469f226
Remove unused functionality in cudf._lib.utils.pyx (#17586)
mroeschke Dec 16, 2024
e975ca3
Move cudf._lib.copying to cudf.core._internals (#17548)
mroeschke Dec 16, 2024
a5ac4bf
Replace direct `cudaMemcpyAsync` calls with utility functions (within…
vuule Dec 16, 2024
e9e34e6
Stop memory_resource.hpp from including itself (#17603)
vyasr Dec 17, 2024
5802d34
Correctly accept a `pandas.CategoricalDtype(pandas.IntervalDtype(...)…
mroeschke Dec 17, 2024
c650bf7
Move cudf._lib.stream_compaction to cudf.core._internals (#17456)
mroeschke Dec 17, 2024
187053a
Remove cudf._lib.string_casting in favor of inlining pylibcudf (#17460)
mroeschke Dec 17, 2024
becfacc
Use `[[nodiscard]]` attribute before `__device__` (#17608)
vuule Dec 17, 2024
0058b52
Fix ``dask_cudf.read_csv`` (#17612)
rjzamora Dec 17, 2024
e5753e3
Add Avro Reader options classes to pylibcudf (#17599)
Matt711 Dec 17, 2024
d742599
Bump the oldest `pyarrow` version to `14.0.2` in test matrix (#17611)
galipremsagar Dec 17, 2024
24aacb2
A couple of fixes in rapids-logger usage (#17588)
vyasr Dec 17, 2024
267c7f2
Fix memcheck error in ReplaceTest.NormalizeNansAndZerosMutable gtest …
davidwendt Dec 17, 2024
b9760ac
Remove cudf._lib.interop in favor of inlining pylibcudf (#17555)
mroeschke Dec 17, 2024
fb896f3
Use `host_vector` in `flatten_single_pass_aggs` (#17605)
vuule Dec 18, 2024
b096182
Remove patch that is only needed for clang-tidy to run on test files …
vyasr Dec 18, 2024
f3caf09
Add JSON Writer options classes to pylibcudf (#17606)
Matt711 Dec 18, 2024
a081a57
update telemetry actions to fluent-bit friendly style (#17615)
msarahan Dec 18, 2024
8e2949f
First Commit isclose depreciation
enoch-gives-thanks Nov 17, 2024
d27c5e5
Merge branch 'pull-request/#13593' of https://github.com/enoch-gives-…
isVoid Dec 20, 2024
6159c39
Revert "Merge branch 'pull-request/#13593' of https://github.com/enoc…
isVoid Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions python/cudf/cudf/core/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -5322,6 +5322,29 @@ def isclose(a, b, rtol=1e-05, atol=1e-08, equal_nan=False):
5 False
dtype: bool
"""
warnings.warn(
"`cudf.close` is deprecated and will be removed in a future version of cudf. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"`cudf.close` is deprecated and will be removed in a future version of cudf. "
"`cudf.isclose` is deprecated and will be removed in a future version of cudf. "

'''
import cupy as cp
import pandas as pd
from cudf.core.column import (
as_column,
)

a = pd.array([1.0, 2.0, None])
b = pd.array([1.0, 2.1, None])

a_col = as_column(a)
a_array = cupy.asarray(a_col.data_array_view(mode="read"))

b_col = as_column(b)
b_array = cupy.asarray(b_col.data_array_view(mode="read"))

result = cp.isclose(a, b, equal_nan=True)
print(result) # Output: [ True False True]
''',
Comment on lines +5327 to +5345
Copy link
Contributor

@bdice bdice Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We noted in #13593: "As part of the deprecation, we decided to add a warning message indicating how to support nulls while using cupy.isclose." However, I am not sure if this is the right code snippet.

The code we want to give to the user as a replacement for this deprecated code path is essentially the current implementation in this method. Basically it has two steps:

  • Call cupy.isclose to see if the values are "close" to each other. This does not account for null values in the input.
  • Compare the null masks of each input. If equal_nan is False, we mark all null values as False ("not close") in the result. If equal_nan is True, we set the values where one column's input is null as False and the values where both columns' input are null as True.

I would suggest we add this snippet to the page "Working with missing data": https://docs.rapids.ai/api/cudf/stable/user_guide/missing-data/

Then we can link to this snippet in the docs from the deprecated method's docstring and in the deprecation warning.

Does that make sense? Let me know if you have questions.

FutureWarning
)

if not can_convert_to_column(a):
raise TypeError(
Expand Down
Loading