Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread_index_type in binary-ops jit kernel.cu #17420

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Use thread_index_type in binary-ops jit kernel.cu #17420

merged 1 commit into from
Nov 26, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Follow on to #17354 to prevent overflow in jit kernel binary-ops.
This uses the thread_index_type directly since the detail/utilities/cuda.cuh cannot be included in the jit'd kernel source.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 22, 2024
@davidwendt davidwendt self-assigned this Nov 22, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 22, 2024
@davidwendt davidwendt marked this pull request as ready for review November 22, 2024 21:23
@davidwendt davidwendt requested a review from a team as a code owner November 22, 2024 21:23
PointKernel
PointKernel approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. And thanks for the quick iterations!

@GregoryKimball GregoryKimball mentioned this pull request Nov 25, 2024
Open
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e7022fb into rapidsai:branch-25.02 Nov 26, 2024
104 checks passed
@davidwendt davidwendt deleted the blockdim-binops-kernel branch November 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@PointKernel PointKernel PointKernel approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @PointKernel @mhaseeb123