Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream-ordering in copying APIs #17435

Open
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from
Open

Expose stream-ordering in copying APIs #17435

wants to merge 3 commits into from

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Nov 25, 2024

Description

Adds stream parameter to

cudf::contiguous_split
cudf::chunked_pack::chunked_pack
cudf::chunked_pack::create
cudf::pack

Added stream gtests to verify correct stream forwarding.

Reference: #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@shrshi shrshi added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 25, 2024
@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 25, 2024
@shrshi shrshi marked this pull request as ready for review November 26, 2024 07:25
@shrshi shrshi requested review from a team as code owners November 26, 2024 07:25
ttnghia
ttnghia reviewed Nov 26, 2024
View reviewed changes
java/src/main/native/src/TableJni.cpp
Comment on lines +4200 to +4202
auto temp_mr = memoryResourceHandle != 0
? reinterpret_cast<rmm::mr::device_memory_resource*>(memoryResourceHandle)
: cudf::get_current_device_resource_ref();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can this variable be assigned to values of different types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia left review comments

@davidwendt davidwendt davidwendt approved these changes

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@shrshi shrshi

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
libcudf
Status: Burndown
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrshi @ttnghia @davidwendt