Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable binaryop build without relying on relaxed constexpr #17598

Draft
wants to merge 8 commits into
base: branch-25.02
Choose a base branch
from
Draft

Enable binaryop build without relying on relaxed constexpr #17598

wants to merge 8 commits into from

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Dec 16, 2024 •
edited
Loading

Description

Contributes to #7795

This PR updates binaryop to build without depending on the relaxed constexpr build option.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added the 2 - In Progress Currently a work in progress label Dec 16, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 16, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel
Copy link
Member Author

/ok to test

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Dec 16, 2024
@PointKernel PointKernel changed the title Remove relaxed constexpr Enable binaryop build without relying on relaxed constexpr Dec 16, 2024
@github-actions github-actions bot removed the CMake CMake build issue label Dec 16, 2024
@PointKernel
Copy link
Member Author

/ok to test

@PointKernel PointKernel added feature request New feature or request non-breaking Non-breaking change labels Dec 20, 2024
@PointKernel
Copy link
Member Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PointKernel PointKernel

Labels
2 - In Progress Currently a work in progress feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PointKernel