Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce some simple benchmarks for rolling window aggregations #17613

Open
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from
Open

Introduce some simple benchmarks for rolling window aggregations #17613

wants to merge 3 commits into from

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Dec 17, 2024

Description

Previously we did not have any benchmarks for rolling aggregations. Introduce some, so we can measure the effects of any performance improvements we might make.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner December 17, 2024 18:15
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Dec 17, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2024
@mythrocks mythrocks self-requested a review December 17, 2024 19:20
mythrocks
mythrocks approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor nit, but otherwise, LGTM!

cpp/benchmarks/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/benchmarks/rolling/grouped_rolling_sum.cpp Show resolved Hide resolved
@mythrocks
Copy link
Contributor

I've re-kicked the CI, because of transient failures.

@wence- wence- force-pushed the wence/fea/rolling-benchmark branch from f1a6a36 to cb2530f Compare December 18, 2024 11:58
@wence- wence- mentioned this pull request Dec 18, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@vyasr vyasr vyasr approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@wence- wence-

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @mythrocks @vyasr