-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stream parameters in pylibcudf IO APIs #17620
Draft
Matt711
wants to merge
23
commits into
rapidsai:branch-25.02
Choose a base branch
from
Matt711:fea/plc/io/streams
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e27cad2
Add stream parameters in pylibcudf IO APIs
Matt711 a72988f
add remaining streams
Matt711 76ffc61
Merge branch 'branch-25.02' into fea/plc/io/streams
Matt711 48fc8a9
clean up
Matt711 8cf0eb1
use stream
Matt711 dee9fda
add stream to parquet_chunked_writer
Matt711 b06dabc
add stream to orc_chunked_writer
Matt711 4fa1a1a
Update python/pylibcudf/pylibcudf/io/csv.pyx
Matt711 a60f800
Update python/pylibcudf/pylibcudf/io/csv.pyx
Matt711 5727aa1
Update python/pylibcudf/pylibcudf/io/json.pyx
Matt711 a8da383
Merge branch 'branch-25.02' into fea/plc/io/streams
Matt711 9d1cc92
clean up
Matt711 8477869
fix typo
Matt711 e117d64
add stream param to cpp_read_orc
Matt711 0fd96db
Merge branch 'branch-25.02' into fea/plc/io/streams
Matt711 8758baa
Merge branch 'branch-25.02' into fea/plc/io/streams
Matt711 3913229
add a test
Matt711 5affbbc
Update python/pylibcudf/pylibcudf/io/json.pyx
Matt711 218e73b
Update python/pylibcudf/pylibcudf/io/json.pyx
Matt711 c29cdc4
remove stream param from avro reader
Matt711 9f7e87e
clean up
Matt711 3f84e5c
clean up
Matt711 f34b519
Merge branch 'branch-25.02' into fea/plc/io/streams
Matt711 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ from pylibcudf.libcudf.io.avro cimport ( | |
read_avro as cpp_read_avro, | ||
) | ||
from pylibcudf.libcudf.types cimport size_type | ||
from rmm._cuda.stream cimport Stream | ||
|
||
__all__ = ["read_avro", "AvroReaderOptions", "AvroReaderOptionsBuilder"] | ||
|
||
|
@@ -126,7 +127,8 @@ cdef class AvroReaderOptionsBuilder: | |
|
||
|
||
cpdef TableWithMetadata read_avro( | ||
AvroReaderOptions options | ||
AvroReaderOptions options, | ||
Stream stream = None, | ||
): | ||
""" | ||
Read from Avro format. | ||
|
@@ -141,7 +143,9 @@ cpdef TableWithMetadata read_avro( | |
options: AvroReaderOptions | ||
Settings for controlling reading behavior | ||
""" | ||
if stream is None: | ||
stream = Stream() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to streamline this. Maybe we can use a default besides |
||
with nogil: | ||
c_result = move(cpp_read_avro(options.c_obj)) | ||
c_result = move(cpp_read_avro(options.c_obj, stream.view())) | ||
|
||
return TableWithMetadata.from_libcudf(c_result) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
= *
do in Cython? I don't think I've used this syntax but I have seen it in a few places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indicates the argument is optional: ref