-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public APIs to Access Underlying cudf
and pandas
Objects from cudf.pandas
Proxy Objects
#17629
base: branch-25.02
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good to me. But I think we should add a bullet to the "Are there any limitations?" section of this faq.md
. And it should describe the implications for users of cudf.pandas
and third-party libraries that are "cudf aware." For example, they could get a cupy array (not a numpy array) when working with xgboost. What do you think?
@@ -204,6 +204,12 @@ def _fsproxy_fast_to_slow(self): | |||
return fast_to_slow(self._fsproxy_wrapped) | |||
return self._fsproxy_wrapped | |||
|
|||
def get_cudf_pandas_fast_object(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend that we avoid fast/slow names in the public API. I think get_cudf_object()
is sufficient. Or possibly as_cudf()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we use reserved names like __as_cudf__()
to make it more obvious that this is a protocol for library developers and not intended for users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We proxy numpy objects too, we will also have to keep that in mind to name these API. How about these names:
__as_fast_object__()
__as_gpu_object__()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like (2). Are there any other public APIs involving words like fast/slow or GPU/CPU?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a dunder name is appropriate. Those are typically for protocols that may be implemented across libraries as a standard, not something that single library decides on for itself. I do agree with avoiding fast/slow names, although we may eventually have to rework this if we rip the proxy out of cudf to make it easier for libraries like cuml to reuse. For now as_gpu_object
seems good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dunder idea was that maybe this should be reserved for other libraries as a documented “protocol” and not presented as a user API. Closer to what IPython does with fancy reprs than the Array API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're thinking of IPython's _repr_html_
, note that that is not a dunder but rather uses single underscores on either side (e.g. HTML._repr_html_
). Conversely, the __html__
protocol is cross-library and implemented by other libraries (although I don't know exactly how wide the adoption is, I have seen it in a few other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks for the correction.
Description
Fixes: #17524
This PR introduces methods to access the real underlying
cudf
andpandas
objects fromcudf.pandas
proxy objects. These methods ensure compatibility with libraries that arecudf
orpandas
aware.Changes:
get_cudf_pandas_fast_object()
andget_cudf_pandas_slow_object()
methods.Checklist