Fix possible int overflow in compute_mixed_join_output_size #17633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
davidwendt
commented
Dec 19, 2024
| @@ -928,7 +928,7 @@ __launch_bounds__(block_size) CUDF_KERNEL | |||
| get_json_object_options options) | |||
| { | |||
| auto tid = cudf::detail::grid_1d::global_thread_id(); | |||
| auto const stride = cudf::thread_index_type{blockDim.x} * cudf::thread_index_type{gridDim.x}; | |||
| auto const stride = cudf::detail::grid_1d::grid_stride(); | |||
There was a problem hiding this comment.
Just a cleanup included here for convenience.
davidwendt
commented
Dec 19, 2024
| @@ -80,7 +80,7 @@ CUDF_KERNEL void __launch_bounds__(block_size) | |||
| auto count_equality = pair_expression_equality<has_nulls>{ | |||
| evaluator, thread_intermediate_storage, swap_tables, equality_probe}; | |||
|
|
|||
| for (cudf::size_type outer_row_index = start_idx; outer_row_index < outer_num_rows; | |||
| for (auto outer_row_index = start_idx; outer_row_index < outer_num_rows; | |||
| outer_row_index += stride) { | |||
There was a problem hiding this comment.
Adding stride to outer_row_index when start_index (thread-index) is within block-size of max int32 will cause it to overflow.
bdice
approved these changes
Dec 19, 2024
vuule
approved these changes
Dec 19, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes possible integer overflow condition when the number of rows is near max int32 in
compute_mixed_join_output_sizekernel function.Reference #10368
Checklist